beremiz

Conform to pep8 and pylint :

2019-04-07, Edouard Tisserant
8fb5c6eddc72
Conform to pep8 and pylint :

pep8 version: 2.3.1
./ConfigTreeNode.py:130:49: E231 missing whitespace after ','
./editors/Viewer.py:643:24: E128 continuation line under-indented for visual indent
./editors/Viewer.py:670:12: E221 multiple spaces before operator
./editors/Viewer.py:671:13: E221 multiple spaces before operator
./editors/Viewer.py:2138:52: E203 whitespace before ':'
./editors/Viewer.py:2139:66: W291 trailing whitespace
./controls/VariablePanel.py:154:25: E231 missing whitespace after ','
./controls/LocationCellEditor.py:88:1: W293 blank line contains whitespace
./controls/LocationCellEditor.py:191:25: E221 multiple spaces before operator
./controls/LocationCellEditor.py:200:17: E128 continuation line under-indented for visual indent

pylint 1.8.3,
************* Module controls.LocationCellEditor
controls/LocationCellEditor.py:200: [C0330(bad-continuation), ] Wrong continued indentation (add 9 spaces).
_("Selected location is identical to previous one"))
^ |
************* Module controls.VariablePanel
controls/VariablePanel.py:154: [E1601(print-statement), VariableTable.SetValue] print statement used
************* Module editors.Viewer
editors/Viewer.py:643: [C0330(bad-continuation), ] Wrong continued indentation (add 1 space).
self.GetAddMenuCallBack(self.AddNewComment))
^|
editors/Viewer.py:598: [W0612(unused-variable), Viewer.AddDivergenceMenuItems] Unused variable 'add_branch'
editors/Viewer.py:1655: [E0602(undefined-variable), Viewer.PopupConnectionMenu] Undefined variable 'variable_type'
editors/Viewer.py:1649: [W0612(unused-variable), Viewer.PopupConnectionMenu] Unused variable 'connection_type'
************* Module connectors.PYRO.PSK_Adapter
#!/usr/bin/env python
# -*- coding: utf-8 -*-
# This file is part of Beremiz, a Integrated Development Environment for
# programming IEC 61131-3 automates supporting plcopen standard and CanFestival.
#
# Copyright (C) 2017: Andrey Skvortsov
#
# See COPYING file for copyrights details.
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
from __future__ import absolute_import
from __future__ import division
import unittest
import time
import wx
import conftest
import controls.CustomIntCtrl
class TestCustomIntCtrl(unittest.TestCase):
def setUp(self):
self.app = wx.App()
self.frame = wx.Frame(None)
def tearDown(self):
self.frame.Destroy()
wx.CallAfter(self.app.Exit)
self.app.MainLoop()
def testMaxLimit(self):
"""Test working upper bound"""
self.AddControls()
self.int_ctrl.SetValue(self.max_val + 100)
self.ProcessEvents()
self.txt_ctrl.SetFocus()
self.ProcessEvents()
self.assertEqual(self.int_ctrl.GetValue(), self.max_val)
def testMinLimit(self):
"""Test working lower bound"""
self.AddControls()
self.int_ctrl.SetValue(self.min_val - 100)
self.ProcessEvents()
self.txt_ctrl.SetFocus()
self.ProcessEvents()
self.assertEqual(self.int_ctrl.GetValue(), self.min_val)
def testCorrectValue(self):
"""Test case if no limiting is necessary"""
self.AddControls()
val = (self.max_val + self.min_val) // 2
self.int_ctrl.SetValue(val)
self.ProcessEvents()
self.txt_ctrl.SetFocus()
self.ProcessEvents()
self.assertEqual(self.int_ctrl.GetValue(), val)
def testEventBinding(self):
"""Test event sending after edit and bound checks are done"""
self.AddControls()
self.event_happend = False
def EventHandler(event):
self.event_happend = True
event.Skip()
self.int_ctrl.Bind(controls.CustomIntCtrl.EVT_CUSTOM_INT, EventHandler)
val = (self.max_val + self.min_val) // 2
self.int_ctrl.SetValue(val)
self.ProcessEvents()
self.txt_ctrl.SetFocus()
self.ProcessEvents()
self.txt_ctrl.SetFocus()
self.ProcessEvents()
self.assertEqual(self.int_ctrl.GetValue(), val)
self.assertTrue(self.event_happend)
def testLongNumbers(self):
"""Test support of long integer"""
self.AddControls()
val = 40000000000
self.int_ctrl.SetMax(val)
self.int_ctrl.SetValue(val)
self.ProcessEvents()
self.txt_ctrl.SetFocus()
self.ProcessEvents()
self.assertEqual(val, val)
def ProcessEvents(self):
for dummy in range(0, 10):
wx.Yield()
time.sleep(0.01)
def AddControls(self):
vs = wx.BoxSizer(wx.VERTICAL)
self.int_ctrl = controls.CustomIntCtrl(self.frame)
self.txt_ctrl = wx.TextCtrl(self.frame)
vs.Add(self.int_ctrl, 0, wx.ALIGN_CENTRE | wx.ALL, 5)
vs.Add(self.txt_ctrl, 0, wx.ALIGN_CENTRE | wx.ALL, 5)
self.frame.SetSizer(vs)
vs.Fit(self.frame)
self.frame.Show()
self.frame.Raise()
self.min_val = 50
self.max_val = 100
self.int_ctrl.SetBounds(self.min_val, self.max_val)
self.ProcessEvents()
if __name__ == '__main__':
conftest.init_environment()
unittest.main()