beremiz

Fix various pylint and pep8 errors

2019-03-13, Andrey Skvortsov
eb4a4cc41914
Fix various pylint and pep8 errors

Check basic code-style problems for PEP-8
pep8 version: 2.4.0
./connectors/PYRO/__init__.py:57:43: E261 at least two spaces before inline comment
./connectors/SchemeEditor.py:29:21: E128 continuation line under-indented for visual indent
./controls/IDBrowser.py:101:23: E127 continuation line over-indented for visual indent
./controls/IDBrowser.py:102:23: E127 continuation line over-indented for visual indent

Check for problems using pylint ...
No config file found, using default configuration
pylint 1.9.4,
astroid 1.6.5
Python 2.7.16rc1 (default, Feb 18 2019, 11:05:09)
[GCC 8.2.0]
Use multiple threads for pylint
Using config file /home/developer/WorkData/PLC/beremiz/beremiz/.pylint
************* Module connectors.PYRO_dialog
connectors/PYRO_dialog.py:9: [W0611(unused-import), ] Unused import wx
************* Module connectors
connectors/__init__.py:32: [W1652(deprecated-types-field), ] Accessing a deprecated fields on the types module
connectors/__init__.py:32: [C0411(wrong-import-order), ] standard import "from types import ClassType" should be placed before "from connectors.ConnectorBase import ConnectorBase"
************* Module connectors.PYRO.PSK_Adapter
connectors/PYRO/PSK_Adapter.py:7: [C0411(wrong-import-order), ] standard import "import ssl" should be placed before "import sslpsk"
************* Module connectors.SchemeEditor
connectors/SchemeEditor.py:29: [C0330(bad-continuation), ] Wrong continued indentation (add 1 space).
wx.ALIGN_CENTER_VERTICAL),
^|
connectors/SchemeEditor.py:42: [W0631(undefined-loop-variable), SchemeEditor.__init__] Using possibly undefined loop variable 'tag'
************* Module runtime.WampClient
runtime/WampClient.py:138: [W1612(unicode-builtin), WampSession.onJoin] unicode built-in referenced
runtime/WampClient.py:154: [W1612(unicode-builtin), WampSession.publishWithOwnID] unicode built-in referenced
runtime/WampClient.py:346: [W1612(unicode-builtin), PublishEvent] unicode built-in referenced
runtime/WampClient.py:351: [W1612(unicode-builtin), PublishEventWithOwnID] unicode built-in referenced
runtime/WampClient.py:31: [W0611(unused-import), ] Unused str imported from builtins as text
************* Module runtime.PLCObject
runtime/PLCObject.py:35: [W1648(bad-python3-import), ] Module moved in Python 3
runtime/PLCObject.py:35: [C0411(wrong-import-order), ] standard import "import md5" should be placed before "from six.moves import xrange"
runtime/PLCObject.py:36: [C0411(wrong-import-order), ] standard import "from tempfile import mkstemp" should be placed before "from six.moves import xrange"
runtime/PLCObject.py:37: [C0411(wrong-import-order), ] standard import "import shutil" should be placed before "from six.moves import xrange"
runtime/PLCObject.py:38: [C0411(wrong-import-order), ] standard import "from functools import wraps, partial" should be placed before "from six.moves import xrange"
************* Module runtime.Worker
runtime/Worker.py:12: [W1648(bad-python3-import), ] Module moved in Python 3
************* Module runtime.spawn_subprocess
runtime/spawn_subprocess.py:125: [C0325(superfluous-parens), ] Unnecessary parens after 'print' keyword
runtime/spawn_subprocess.py:130: [C0325(superfluous-parens), ] Unnecessary parens after 'print' keyword
runtime/spawn_subprocess.py:125: [E1601(print-statement), ] print statement used
runtime/spawn_subprocess.py:130: [E1601(print-statement), ] print statement used
************* Module controls.IDBrowser
controls/IDBrowser.py:101: [C0330(bad-continuation), ] Wrong continued indentation (remove 5 spaces).
if self.isManager
| ^
controls/IDBrowser.py:102: [C0330(bad-continuation), ] Wrong continued indentation (remove 5 spaces).
else dv.DATAVIEW_CELL_INERT),
| ^
************* Module Beremiz_service
Beremiz_service.py:34: [W0611(unused-import), ] Unused import __builtin__
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<PyFile>
<variables>
<variable name="WiiNunchuckStickX" type="INT"/>
<variable name="WiiNunchuckStickY" type="INT"/>
<variable name="WiiNunchuckAccX" type="INT"/>
<variable name="WiiNunchuckAccY" type="INT"/>
<variable name="WiiNunchuckAccZ" type="INT"/>
<variable name="WiiNunchuckButtons" type="WORD"/>
<variable name="WiiButtons" type="WORD"/>
</variables>
<globals>
<![CDATA[
import cwiid,commands,sys,re,os,time
wiimote = None
WIIMOTE_ADDR_MODEL = re.compile("((?:[0-9A-F]{2})(?::[0-9A-F]{2}){5})\s*Nintendo")
nunchuckzero = None
def Wiimote_cback(messages, time):
global nunchuckzero
state = dict(messages)
bts = state.get(cwiid.MESG_BTN, None)
if bts is not None:
PLCGlobals.WiiButtons = bts
nunchuck = state.get(cwiid.MESG_NUNCHUK, None)
if nunchuck is not None:
PLCGlobals.WiiNunchuckButtons = nunchuck['buttons']
X,Y = nunchuck['stick']
PLCGlobals.WiiNunchuckAccX = nunchuck['acc'][cwiid.X]
PLCGlobals.WiiNunchuckAccY = nunchuck['acc'][cwiid.Y]
PLCGlobals.WiiNunchuckAccZ = nunchuck['acc'][cwiid.Z]
if nunchuckzero is None:
nunchuckzero = X,Y
(PLCGlobals.WiiNunchuckStickX,
PLCGlobals.WiiNunchuckStickY) = X-nunchuckzero[0],Y-nunchuckzero[1]
def Connect_Wiimote(connected_callback):
global wiimote,nunchuckzero
mac_addr = ''
try:
mac_addr = file("wiimac.txt","rt").read()
except:
PLCObject.LogMessage("Wiimote MAC unknown, scanning bluetooth")
output = commands.getoutput("hcitool scan")
result = WIIMOTE_ADDR_MODEL.search(output)
if result is not None:
mac_addr = result.group(1)
PLCObject.LogMessage("Found Wiimote with MAC %s"%mac_addr)
file("wiimac.txt","wt").write(mac_addr)
# Connect to wiimote
if not mac_addr:
PLCObject.LogMessage("Connection to unknown Wiimote...")
wiimote = cwiid.Wiimote()
else:
PLCObject.LogMessage("Connection to Wiimote %s..."%mac_addr)
wiimote = cwiid.Wiimote(mac_addr)
if wiimote is not None:
nunchuckzero = None
wiimote.rpt_mode = cwiid.RPT_BTN | cwiid.RPT_EXT
# use the callback interface
wiimote.mesg_callback = Wiimote_cback
wiimote.enable(cwiid.FLAG_MESG_IFC)
connected_callback(mac_addr)
PLCObject.LogMessage("Wiimote %s Connected"%mac_addr)
else:
PLCObject.LogMessage("Wiimote %s not found"%mac_addr)
os.remove("wiimac.txt")
connected_callback(None)
def Disconnect_Wiimote():
global wiimote
if wiimote is not None:
wiimote.disable(cwiid.FLAG_MESG_IFC)
time.sleep(0.1)
wiimote.close()
wiimote = None
PLCObject.LogMessage("Wiimote disconnected")
]]>
</globals>
<init>
<![CDATA[
]]>
</init>
<cleanup>
<![CDATA[
Disconnect_Wiimote()
]]>
</cleanup>
<start>
<![CDATA[
]]>
</start>
<stop>
<![CDATA[
]]>
</stop>
</PyFile>