--- a/svghmi/gen_index_xhtml.xslt Tue Sep 15 13:57:06 2020 +0200
+++ b/svghmi/gen_index_xhtml.xslt Thu Sep 17 11:30:22 2020 +0200
@@ -915,7 +915,7 @@
<xsl:when test="not(@index)">
<xsl:when test="not(@type)">
- <xsl:message terminate="yes">
+ <xsl:message terminate="no"> <xsl:text>Widget </xsl:text>
<xsl:value-of select="$widget/@type"/>
<xsl:text> id="</xsl:text>
@@ -924,6 +924,10 @@
<xsl:value-of select="@value"/>
<xsl:text>" in HMI tree</xsl:text>
+ <xsl:text>undefined</xsl:text> + <xsl:if test="position()!=last()"> <xsl:when test="@type = 'PAGE_LOCAL'">
@@ -1179,6 +1183,8 @@
<xsl:text> let index = this.get_variable_index(i);
+ <xsl:text> if(index == undefined) continue; <xsl:text> subscribers(index).add(this);
@@ -1197,6 +1203,8 @@
<xsl:text> let realindex = this.get_variable_index(index);
+ <xsl:text> if(realindex == undefined) continue; <xsl:text> let cached_val = cache[realindex];
<xsl:text> if(cached_val != undefined)
@@ -1231,9 +1239,13 @@
- <xsl:text> change_hmi_value(index,opstr) {
- <xsl:text> return change_hmi_value(this.get_variable_index(index), opstr);
+ <xsl:text> change_hmi_value(index, opstr) { + <xsl:text> let realindex = this.get_variable_index(index); + <xsl:text> if(realindex == undefined) return undefined; + <xsl:text> return change_hmi_value(realindex, opstr); @@ -1241,7 +1253,11 @@
<xsl:text> apply_hmi_value(index, new_val) {
- <xsl:text> return apply_hmi_value(this.get_variable_index(index), new_val);
+ <xsl:text> let realindex = this.get_variable_index(index); + <xsl:text> if(realindex == undefined) return undefined; + <xsl:text> return apply_hmi_value(realindex, new_val); @@ -1255,6 +1271,8 @@
<xsl:text> let refindex = this.get_variable_index(i);
+ <xsl:text> if(refindex == undefined) continue; <xsl:text> if(index == refindex) {
@@ -1490,41 +1508,85 @@
+ <xsl:text> plc_lock = false; <xsl:text> active_style = undefined;
<xsl:text> inactive_style = undefined;
- <xsl:text> // TODO decouple update of DOM from event (i.e use animate())
- <xsl:text> // TODO State of the button should distinguish UI feedbak from current PLC value
- <xsl:text> on_mouse_down(evt) {
- <xsl:text> if (this.active_style && this.inactive_style) {
- <xsl:text> this.active_elt.setAttribute("style", this.active_style);
- <xsl:text> this.inactive_elt.setAttribute("style", "display:none");
+ <xsl:text> dispatch(value) { + <xsl:text> this.button_release(); - <xsl:text> this.apply_hmi_value(0, 1);
- <xsl:text> // TODO inhibit all mouse/touch events except mouse up (in other word grab cursor)
- <xsl:text> on_mouse_up(evt) {
+ <xsl:text> on_mouse_down(evt) { + <xsl:text> if (this.active_style && this.inactive_style) { + <xsl:text> this.active_elt.setAttribute("style", this.active_style); + <xsl:text> this.inactive_elt.setAttribute("style", "display:none"); + <xsl:text> this.apply_hmi_value(0, 1); + <xsl:text> this.plc_lock = false; + <xsl:text> on_mouse_up(evt) { + <xsl:text> this.button_release(); + <xsl:text> button_release(){ + <xsl:text> if(!this.plc_lock){ + <xsl:text> this.plc_lock = true; + <xsl:text> if (this.active_style && this.inactive_style) { + <xsl:text> this.active_elt.setAttribute("style", "display:none"); + <xsl:text> this.inactive_elt.setAttribute("style", this.inactive_style); + <xsl:text> this.apply_hmi_value(0, 0); + <xsl:text> this.active_style = this.active_elt ? this.active_elt.style.cssText : undefined; + <xsl:text> this.inactive_style = this.inactive_elt ? this.inactive_elt.style.cssText : undefined; <xsl:text> if (this.active_style && this.inactive_style) {
@@ -1534,39 +1596,13 @@
- <xsl:text> this.apply_hmi_value(0, 0);
- <xsl:text> // TODO release inhibited events
- <xsl:text> // TODO : move to widget_defs so that we can have generated string literals directly
- <xsl:text> this.active_style = this.active_elt ? this.active_elt.style.cssText : undefined;
- <xsl:text> this.inactive_style = this.inactive_elt ? this.inactive_elt.style.cssText : undefined;
- <xsl:text> if (this.active_style && this.inactive_style) {
- <xsl:text> this.active_elt.setAttribute("style", "display:none");
- <xsl:text> this.inactive_elt.setAttribute("style", this.inactive_style);
- <xsl:text> this.element.setAttribute("onmousedown", "hmi_widgets[\""+this.element_id+"\"].on_mouse_down(evt)");
- <xsl:text> this.element.setAttribute("onmouseup", "hmi_widgets[\""+this.element_id+"\"].on_mouse_up(evt)");
+ <xsl:text> this.element.setAttribute("onmousedown", "hmi_widgets["+this.element_id+"].on_mouse_down(evt)"); + <xsl:text> this.element.setAttribute("onmouseup", "hmi_widgets["+this.element_id+"].on_mouse_up(evt)"); @@ -4718,47 +4754,163 @@
<xsl:text> range = undefined;
+ <xsl:text> handle_orig = undefined; + <xsl:text> scroll_size = 10; + <xsl:text> min_size = 0.07; <xsl:text> fi = undefined;
- <xsl:text> svg_dist = undefined;
+ <xsl:text> curr_value = 0; <xsl:text> enTimer = false;
+ <xsl:text> handle_click = undefined; + <xsl:text> last_drag = false; <xsl:text> dispatch(value) {
+ <xsl:text> //save current value inside widget + <xsl:text> this.curr_value = value; <xsl:text> if(this.value_elt)
<xsl:text> this.value_elt.textContent = String(value);
- <xsl:text> this.update_DOM(value, this.handle_elt);
+ <xsl:text> //don't update if draging and setpoint ghost doesn't exist + <xsl:text> if(!this.drag || (this.setpoint_elt != undefined)){ + <xsl:text> this.update_DOM(value, this.handle_elt); - <xsl:text> last_drag = false;
<xsl:text> update_DOM(value, elt){
<xsl:text> let [min,max,start,totallength] = this.range;
- <xsl:text> let length = Math.max(0,Math.min(totallength,(Number(value)-min)*totallength/(max-min)));
- <xsl:text> let tip = this.range_elt.getPointAtLength(length);
- <xsl:text> elt.setAttribute('transform',"translate("+(tip.x-start.x)+","+(tip.y-start.y)+")");
+ <xsl:text> // check if handle is resizeable + <xsl:text> if (this.scroll_size != undefined){ //size changes + <xsl:text> //get parameters + <xsl:text> let length = Math.max(min,Math.min(max,(Number(value)-min)*max/(max-min))); + <xsl:text> let tip = this.range_elt.getPointAtLength(length); + <xsl:text> let handle_min = totallength*this.min_size; + <xsl:text> let step = 1; + <xsl:text> //check if range is bigger than max displayed and recalculate step + <xsl:text> if ((totallength/handle_min) < (max-min+1)){ + <xsl:text> step = (max-min+1)/(totallength/handle_min-1); + <xsl:text> let kx,ky,offseY,offseX = undefined; + <xsl:text> //scale on x or y axes + <xsl:text> if (this.fi > 0.75){ + <xsl:text> //get scale factor + <xsl:text> if(step > 1){ + <xsl:text> ky = handle_min/this.handle_orig.height; + <xsl:text> ky = (totallength-handle_min*(max-min))/this.handle_orig.height; + <xsl:text> //get 0 offset to stay inside range + <xsl:text> offseY = start.y - (this.handle_orig.height + this.handle_orig.y) * ky; + <xsl:text> //get distance from value + <xsl:text> tip.y =this.range_elt.getPointAtLength(0).y - length/step *handle_min; + <xsl:text> //get scale factor + <xsl:text> if(step > 1){ + <xsl:text> kx = handle_min/this.handle_orig.width; + <xsl:text> kx = (totallength-handle_min*(max-min))/this.handle_orig.width; + <xsl:text> //get 0 offset to stay inside range + <xsl:text> offseX = start.x - (this.handle_orig.x * kx); + <xsl:text> //get distance from value + <xsl:text> tip.x =this.range_elt.getPointAtLength(0).x + length/step *handle_min; + <xsl:text> elt.setAttribute('transform',"matrix("+(kx)+" 0 0 "+(ky)+" "+(tip.x-start.x+offseX)+" "+(tip.y-start.y+offseY)+")"); + <xsl:text> else{ //size stays the same + <xsl:text> let length = Math.max(0,Math.min(totallength,(Number(value)-min)*totallength/(max-min))); + <xsl:text> let tip = this.range_elt.getPointAtLength(length); + <xsl:text> elt.setAttribute('transform',"translate("+(tip.x-start.x)+","+(tip.y-start.y)+")"); + <xsl:text> // show or hide ghost if exists <xsl:text> if(this.setpoint_elt != undefined){
@@ -4786,6 +4938,8 @@
<xsl:text> on_release(evt) {
+ <xsl:text> //unbind events <xsl:text> window.removeEventListener("touchmove", this.on_bound_drag, true);
<xsl:text> window.removeEventListener("mousemove", this.on_bound_drag, true);
@@ -4798,26 +4952,38 @@
<xsl:text> window.removeEventListener("touchcancel", this.bound_on_release, true);
+ <xsl:text> //reset drag flag <xsl:text> if(this.drag){
<xsl:text> this.drag = false;
+ <xsl:text> // get final position <xsl:text> this.update_position(evt);
+ <xsl:text> //ignore drag event for X amount of time and if not selected <xsl:text> if(this.enTimer && this.drag){
<xsl:text> this.update_position(evt);
<xsl:text> this.enTimer = false;
@@ -4834,16 +5000,18 @@
<xsl:text> var html_dist = 0;
+ <xsl:text> let [min,max,start,totallength] = this.range; <xsl:text> //calculate size of widget in html
<xsl:text> var range_borders = this.range_elt.getBoundingClientRect();
+ <xsl:text> var [minX,minY,maxX,maxY] = [range_borders.left,range_borders.bottom,range_borders.right,range_borders.top]; <xsl:text> var range_length = Math.sqrt( range_borders.height*range_borders.height + range_borders.width*range_borders.width );
- <xsl:text> var [minX,minY,maxX,maxY] = [range_borders.left,range_borders.bottom,range_borders.right,range_borders.top];
<xsl:text> //get range and mouse coordinates
@@ -4870,81 +5038,153 @@
- <xsl:text> //get handle distance from mouse position
- <xsl:text> if (minX > mouseX && minY < mouseY){
- <xsl:text> html_dist = 0;
- <xsl:text> else if (maxX < mouseX && maxY > mouseY){
- <xsl:text> html_dist = range_length;
- <xsl:text> // calculate distace
+ <xsl:text> // calculate position + <xsl:text> if (this.handle_click){ //if clicked on handle + <xsl:text> let moveDist = 0, resizeAdd = 0; + <xsl:text> let range_percent = 1; + <xsl:text> //set paramters for resizeable handle + <xsl:text> if (this.scroll_size != undefined){ + <xsl:text> // add one more object to stay inside range + <xsl:text> resizeAdd = 1; + <xsl:text> //chack if range is bigger than display option and + <xsl:text> // calculate percent of range with out handle + <xsl:text> if(((max/(max*this.min_size)) < (max-min+1))){ + <xsl:text> range_percent = 1-this.min_size; + <xsl:text> range_percent = 1-(max-max*this.min_size*(max-min))/max; + <xsl:text> //calculate value difference on x or y axis <xsl:text> if(this.fi > 0.7){
- <xsl:text> html_dist = (minY - mouseY)/Math.sin(this.fi);
+ <xsl:text> moveDist = ((max-min+resizeAdd)/(range_length*range_percent))*((this.handle_click[1]-mouseY)/Math.sin(this.fi)); - <xsl:text> html_dist = (mouseX - minX)/Math.cos(this.fi);
+ <xsl:text> moveDist = ((max-min+resizeAdd)/(range_length*range_percent))*((mouseX-this.handle_click[0])/Math.cos(this.fi)); - <xsl:text> //check if in range
- <xsl:text> if (html_dist > range_length){
- <xsl:text> html_dist = range_length;
- <xsl:text> else if (html_dist < 0){
+ <xsl:text> this.curr_value = Math.ceil(this.handle_click[2] + moveDist); + <xsl:text> else{ //if clicked on widget + <xsl:text> //get handle distance from mouse position + <xsl:text> if (minX > mouseX && minY < mouseY){ <xsl:text> html_dist = 0;
+ <xsl:text> else if (maxX < mouseX && maxY > mouseY){ + <xsl:text> html_dist = range_length; + <xsl:text> if(this.fi > 0.7){ + <xsl:text> html_dist = (minY - mouseY)/Math.sin(this.fi); + <xsl:text> html_dist = (mouseX - minX)/Math.cos(this.fi); + <xsl:text> //calculate distance + <xsl:text> this.curr_value=Math.ceil((html_dist/range_length)*(this.range[1]-this.range[0])+this.range[0]); - <xsl:text> this.svg_dist=Math.ceil((html_dist/range_length)*this.range[1]);
- <xsl:text> this.apply_hmi_value(0, this.svg_dist);
- <xsl:text> // update ghost cursor
- <xsl:text> if(this.setpoint_elt != undefined){
- <xsl:text> this.request_animate();
+ <xsl:text> //check if in range + <xsl:text> if (this.curr_value > max){ + <xsl:text> this.curr_value = max; + <xsl:text> else if (this.curr_value < min){ + <xsl:text> this.curr_value = min; + <xsl:text> this.apply_hmi_value(0, this.curr_value); + <xsl:text> //redraw handle + <xsl:text> this.request_animate(); - <xsl:text> this.update_DOM(this.svg_dist, this.setpoint_elt);
+ <xsl:text> // redraw handle on screen refresh + <xsl:text> // check if setpoint(ghost) handle exsist otherwise update main handle + <xsl:text> if(this.setpoint_elt != undefined){ + <xsl:text> this.update_DOM(this.curr_value, this.setpoint_elt); + <xsl:text> this.update_DOM(this.curr_value, this.handle_elt); @@ -4952,10 +5192,16 @@
<xsl:text> on_select(evt){
+ <xsl:text> //enable drag flag and timer <xsl:text> this.drag = true;
<xsl:text> this.enTimer = true;
+ <xsl:text> //bind events <xsl:text> window.addEventListener("touchmove", this.on_bound_drag, true);
<xsl:text> window.addEventListener("mousemove", this.on_bound_drag, true);
@@ -4968,7 +5214,55 @@
<xsl:text> window.addEventListener("touchcancel", this.bound_on_release, true);
- <xsl:text> this.update_position(evt);
+ <xsl:text> // check if handle was pressed + <xsl:text> if (evt.currentTarget == this.handle_elt){ + <xsl:text> //get mouse position on the handle + <xsl:text> let mouseX = undefined; + <xsl:text> let mouseY = undefined; + <xsl:text> if (evt.type.startsWith("touch")){ + <xsl:text> mouseX = Math.ceil(evt.touches[0].clientX); + <xsl:text> mouseY = Math.ceil(evt.touches[0].clientY); + <xsl:text> mouseX = evt.pageX; + <xsl:text> mouseY = evt.pageY; + <xsl:text> //save coordinates and orig value + <xsl:text> this.handle_click = [mouseX,mouseY,this.curr_value]; + <xsl:text> // get new handle position and reset if handle was not pressed + <xsl:text> this.handle_click = undefined; + <xsl:text> this.update_position(evt); + <xsl:text> //prevent next events + <xsl:text> evt.stopPropagation(); @@ -4976,6 +5270,8 @@
+ <xsl:text> //set min max value if not defined <xsl:text> let min = this.min_elt ?
<xsl:text> Number(this.min_elt.textContent) :
@@ -4990,6 +5286,10 @@
+ <xsl:text> // save initial parameters + <xsl:text> this.range_elt.style.strokeMiterlimit="0"; <xsl:text> this.range = [min, max, this.range_elt.getPointAtLength(0),this.range_elt.getTotalLength()];
<xsl:text> let start = this.range_elt.getPointAtLength(0);
@@ -4998,7 +5298,11 @@
<xsl:text> this.fi = Math.atan2(start.y-end.y, end.x-start.x);
+ <xsl:text> this.handle_orig = this.handle_elt.getBBox(); + <xsl:text> //bind functions <xsl:text> this.bound_on_select = this.on_select.bind(this);
@@ -5008,6 +5312,8 @@
+ <xsl:text> this.handle_elt.addEventListener("mousedown", this.bound_on_select); <xsl:text> this.element.addEventListener("mousedown", this.bound_on_select);
<xsl:text> this.element.addEventListener("touchstart", this.bound_on_select);
@@ -5119,23 +5425,23 @@
<xsl:text> dispatch(value) {
- <xsl:text> this.state = value;
- <xsl:text> if (this.state) {
- <xsl:text> this.active_elt.setAttribute("style", this.active_style);
- <xsl:text> this.inactive_elt.setAttribute("style", "display:none");
- <xsl:text> this.state = 0;
- <xsl:text> this.inactive_elt.setAttribute("style", this.inactive_style);
- <xsl:text> this.active_elt.setAttribute("style", "display:none");
- <xsl:text> this.state = 1;
+ <xsl:text> if(this.state != value){ + <xsl:text> this.state = value; + <xsl:text> if (this.state) { + <xsl:text> this.active_elt.setAttribute("style", this.active_style); + <xsl:text> this.inactive_elt.setAttribute("style", "display:none"); + <xsl:text> this.inactive_elt.setAttribute("style", this.inactive_style); + <xsl:text> this.active_elt.setAttribute("style", "display:none"); @@ -5145,6 +5451,24 @@
<xsl:text> on_click(evt) {
+ <xsl:text> if (this.state) { + <xsl:text> this.inactive_elt.setAttribute("style", this.inactive_style); + <xsl:text> this.active_elt.setAttribute("style", "display:none"); + <xsl:text> this.state = 0; + <xsl:text> this.active_elt.setAttribute("style", this.active_style); + <xsl:text> this.inactive_elt.setAttribute("style", "display:none"); + <xsl:text> this.state = 1; <xsl:text> this.apply_hmi_value(0, this.state);
@@ -5159,6 +5483,10 @@
<xsl:text> this.element.setAttribute("onclick", "hmi_widgets['"+this.element_id+"'].on_click(evt)");
+ <xsl:text> this.inactive_elt.setAttribute("style", this.inactive_style); + <xsl:text> this.active_elt.setAttribute("style", "display:none"); --- a/svghmi/widget_slider.ysl2 Tue Sep 15 13:57:06 2020 +0200
+++ b/svghmi/widget_slider.ysl2 Thu Sep 17 11:30:22 2020 +0200
@@ -5,27 +5,85 @@
class SliderWidget extends Widget{
+ handle_orig = undefined;
+ handle_click = undefined; + //save current value inside widget + this.curr_value = value; this.value_elt.textContent = String(value);
- this.update_DOM(value, this.handle_elt);
+ //don't update if draging and setpoint ghost doesn't exist + if(!this.drag || (this.setpoint_elt != undefined)){ + this.update_DOM(value, this.handle_elt);
let [min,max,start,totallength] = this.range;
- let length = Math.max(0,Math.min(totallength,(Number(value)-min)*totallength/(max-min)));
- let tip = this.range_elt.getPointAtLength(length);
- elt.setAttribute('transform',"translate("+(tip.x-start.x)+","+(tip.y-start.y)+")");
+ // check if handle is resizeable + if (this.scroll_size != undefined){ //size changes + let length = Math.max(min,Math.min(max,(Number(value)-min)*max/(max-min))); + let tip = this.range_elt.getPointAtLength(length); + let handle_min = totallength*this.min_size; + //check if range is bigger than max displayed and recalculate step + if ((totallength/handle_min) < (max-min+1)){ + step = (max-min+1)/(totallength/handle_min-1); + let kx,ky,offseY,offseX = undefined; + ky = handle_min/this.handle_orig.height; + ky = (totallength-handle_min*(max-min))/this.handle_orig.height; + //get 0 offset to stay inside range + offseY = start.y - (this.handle_orig.height + this.handle_orig.y) * ky; + //get distance from value + tip.y =this.range_elt.getPointAtLength(0).y - length/step *handle_min; + kx = handle_min/this.handle_orig.width; + kx = (totallength-handle_min*(max-min))/this.handle_orig.width; + //get 0 offset to stay inside range + offseX = start.x - (this.handle_orig.x * kx); + //get distance from value + tip.x =this.range_elt.getPointAtLength(0).x + length/step *handle_min; + elt.setAttribute('transform',"matrix("+(kx)+" 0 0 "+(ky)+" "+(tip.x-start.x+offseX)+" "+(tip.y-start.y+offseY)+")"); + else{ //size stays the same + let length = Math.max(0,Math.min(totallength,(Number(value)-min)*totallength/(max-min))); + let tip = this.range_elt.getPointAtLength(length); + elt.setAttribute('transform',"translate("+(tip.x-start.x)+","+(tip.y-start.y)+")"); + // show or hide ghost if exists if(this.setpoint_elt != undefined){
if(this.last_drag!= this.drag){
@@ -39,22 +97,29 @@
window.removeEventListener("touchmove", this.on_bound_drag, true);
window.removeEventListener("mousemove", this.on_bound_drag, true);
window.removeEventListener("mouseup", this.bound_on_release, true)
window.removeEventListener("touchend", this.bound_on_release, true);
window.removeEventListener("touchcancel", this.bound_on_release, true);
this.update_position(evt);
+ //ignore drag event for X amount of time and if not selected if(this.enTimer && this.drag){
this.update_position(evt);
setTimeout("{hmi_widgets['"+this.element_id+"'].enTimer = true;}", 100);
@@ -63,11 +128,12 @@
+ let [min,max,start,totallength] = this.range; //calculate size of widget in html
var range_borders = this.range_elt.getBoundingClientRect();
+ var [minX,minY,maxX,maxY] = [range_borders.left,range_borders.bottom,range_borders.right,range_borders.top]; var range_length = Math.sqrt( range_borders.height*range_borders.height + range_borders.width*range_borders.width );
- var [minX,minY,maxX,maxY] = [range_borders.left,range_borders.bottom,range_borders.right,range_borders.top];
//get range and mouse coordinates
@@ -81,59 +147,123 @@
- //get handle distance from mouse position
- if (minX > mouseX && minY < mouseY){
- else if (maxX < mouseX && maxY > mouseY){
- html_dist = range_length;
+ if (this.handle_click){ //if clicked on handle + let moveDist = 0, resizeAdd = 0; + //set paramters for resizeable handle + if (this.scroll_size != undefined){ + // add one more object to stay inside range + //chack if range is bigger than display option and + // calculate percent of range with out handle + if(((max/(max*this.min_size)) < (max-min+1))){ + range_percent = 1-this.min_size; + range_percent = 1-(max-max*this.min_size*(max-min))/max; + //calculate value difference on x or y axis - html_dist = (minY - mouseY)/Math.sin(this.fi);
+ moveDist = ((max-min+resizeAdd)/(range_length*range_percent))*((this.handle_click[1]-mouseY)/Math.sin(this.fi)); - html_dist = (mouseX - minX)/Math.cos(this.fi);
+ moveDist = ((max-min+resizeAdd)/(range_length*range_percent))*((mouseX-this.handle_click[0])/Math.cos(this.fi));
- if (html_dist > range_length){
- html_dist = range_length;
- else if (html_dist < 0){
+ this.curr_value = Math.ceil(this.handle_click[2] + moveDist); + else{ //if clicked on widget + //get handle distance from mouse position + if (minX > mouseX && minY < mouseY){
+ else if (maxX < mouseX && maxY > mouseY){ + html_dist = range_length; + html_dist = (minY - mouseY)/Math.sin(this.fi); + html_dist = (mouseX - minX)/Math.cos(this.fi); + this.curr_value=Math.ceil((html_dist/range_length)*(this.range[1]-this.range[0])+this.range[0]); - this.svg_dist=Math.ceil((html_dist/range_length)*this.range[1]);
+ if (this.curr_value > max){ + else if (this.curr_value < min){ - this.apply_hmi_value(0, this.svg_dist);
+ this.apply_hmi_value(0, this.curr_value);
+ this.request_animate(); + // redraw handle on screen refresh + // check if setpoint(ghost) handle exsist otherwise update main handle if(this.setpoint_elt != undefined){
- this.request_animate();
+ this.update_DOM(this.curr_value, this.setpoint_elt); + this.update_DOM(this.curr_value, this.handle_elt);
- this.update_DOM(this.svg_dist, this.setpoint_elt);
+ //enable drag flag and timer window.addEventListener("touchmove", this.on_bound_drag, true);
window.addEventListener("mousemove", this.on_bound_drag, true);
window.addEventListener("mouseup", this.bound_on_release, true)
window.addEventListener("touchend", this.bound_on_release, true);
window.addEventListener("touchcancel", this.bound_on_release, true);
- this.update_position(evt);
+ // check if handle was pressed + if (evt.currentTarget == this.handle_elt){ + //get mouse position on the handle + let mouseX = undefined; + let mouseY = undefined; + if (evt.type.startsWith("touch")){ + mouseX = Math.ceil(evt.touches[0].clientX); + mouseY = Math.ceil(evt.touches[0].clientY); + //save coordinates and orig value + this.handle_click = [mouseX,mouseY,this.curr_value]; + // get new handle position and reset if handle was not pressed + this.handle_click = undefined; + this.update_position(evt); + //set min max value if not defined Number(this.min_elt.textContent) :
this.args.length >= 1 ? this.args[0] : 0;
@@ -141,15 +271,20 @@
Number(this.max_elt.textContent) :
this.args.length >= 2 ? this.args[1] : 100;
+ // save initial parameters + this.range_elt.style.strokeMiterlimit="0"; this.range = [min, max, this.range_elt.getPointAtLength(0),this.range_elt.getTotalLength()];
let start = this.range_elt.getPointAtLength(0);
let end = this.range_elt.getPointAtLength(this.range_elt.getTotalLength());
this.fi = Math.atan2(start.y-end.y, end.x-start.x);
+ this.handle_orig = this.handle_elt.getBBox(); this.bound_on_select = this.on_select.bind(this);
this.bound_on_release = this.on_release.bind(this);
this.on_bound_drag = this.on_drag.bind(this);
+ this.handle_elt.addEventListener("mousedown", this.bound_on_select); this.element.addEventListener("mousedown", this.bound_on_select);
this.element.addEventListener("touchstart", this.bound_on_select);
--- a/svghmi/widgets_common.ysl2 Tue Sep 15 13:57:06 2020 +0200
+++ b/svghmi/widgets_common.ysl2 Thu Sep 17 11:30:22 2020 +0200
@@ -29,8 +29,10 @@
- error > Widget «$widget/@type» id="«$eltid»" : No match for path "«@value»" in HMI tree
+ warning > Widget «$widget/@type» id="«$eltid»" : No match for path "«@value»" in HMI tree + > undefined`if "position()!=last()" > ,` when "@type = 'PAGE_LOCAL'"
> "«@value»"`if "position()!=last()" > ,`
when "@type = 'HMI_LOCAL'"
@@ -152,6 +154,7 @@
for(let i = 0; i < this.indexes.length; i++) {
let index = this.get_variable_index(i);
+ if(index == undefined) continue; subscribers(index).add(this);
need_cache_apply.push(this);
@@ -161,6 +164,7 @@
if(!this.unsubscribable) for(let index in this.indexes){
/* dispatch current cache in newly opened page widgets */
let realindex = this.get_variable_index(index);
+ if(realindex == undefined) continue; let cached_val = cache[realindex];
if(cached_val != undefined)
this._dispatch(cached_val, cached_val, index);
@@ -178,18 +182,23 @@
- change_hmi_value(index,opstr) {
- return change_hmi_value(this.get_variable_index(index), opstr);
+ change_hmi_value(index, opstr) { + let realindex = this.get_variable_index(index); + if(realindex == undefined) return undefined; + return change_hmi_value(realindex, opstr); apply_hmi_value(index, new_val) {
- return apply_hmi_value(this.get_variable_index(index), new_val);
+ let realindex = this.get_variable_index(index); + if(realindex == undefined) return undefined; + return apply_hmi_value(realindex, new_val); new_hmi_value(index, value, oldval) {
// TODO avoid searching, store index at sub()
for(let i = 0; i < this.indexes.length; i++) {
let refindex = this.get_variable_index(i);
+ if(refindex == undefined) continue; this._dispatch(value, oldval, i);
--- a/tests/svghmi_v2/plc.xml Tue Sep 15 13:57:06 2020 +0200
+++ b/tests/svghmi_v2/plc.xml Thu Sep 17 11:30:22 2020 +0200
@@ -1,7 +1,7 @@
<?xml version='1.0' encoding='utf-8'?>
<project xmlns:ns1="http://www.plcopen.org/xml/tc6_0201" xmlns:xhtml="http://www.w3.org/1999/xhtml" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns="http://www.plcopen.org/xml/tc6_0201">
<fileHeader companyName="Unknown" productName="Unnamed" productVersion="1" creationDateTime="2019-08-06T14:23:42"/>
- <contentHeader name="Unnamed" modificationDateTime="2020-07-30T12:04:22">
+ <contentHeader name="Unnamed" modificationDateTime="2020-09-15T14:59:06"> @@ -55,6 +55,21 @@
<derived name="HMI_INT"/>
+ <variable name="Toggle"> + <derived name="HMI_BOOL"/> + <variable name="Toggle1"> + <derived name="HMI_BOOL"/> + <variable name="Toggle2"> + <derived name="HMI_BOOL"/> <variable name="MultistateExt">
@@ -88,7 +103,7 @@
<expression>TargetPressure</expression>
<inVariable localId="6" executionOrderId="0" height="25" width="90" negated="false">
- <position x="155" y="220"/>
+ <position x="130" y="60"/> <relPosition x="90" y="10"/>
@@ -100,7 +115,9 @@
<relPosition x="0" y="10"/>
<connection refLocalId="6">
<position x="495" y="230"/>
- <position x="245" y="230"/>
+ <position x="367" y="230"/> + <position x="367" y="70"/> + <position x="220" y="70"/> <expression>TestLocal</expression>
@@ -190,34 +207,12 @@
<expression>TargetPressure</expression>
- <inOutVariable localId="4" executionOrderId="0" height="30" width="60" negatedOut="false" negatedIn="false">
- <position x="510" y="80"/>
- <relPosition x="0" y="15"/>
- <connection refLocalId="6" formalParameter="OUT">
- <position x="510" y="95"/>
- <position x="470" y="95"/>
- <relPosition x="60" y="15"/>
- <expression>Sloth</expression>
<block localId="6" typeName="ADD" executionOrderId="0" height="60" width="65">
<position x="405" y="65"/>
<variable formalParameter="IN1">
<relPosition x="0" y="30"/>
- <connection refLocalId="4">
- <position x="405" y="95"/>
- <position x="385" y="95"/>
- <position x="385" y="50"/>
- <position x="580" y="50"/>
- <position x="580" y="95"/>
- <position x="570" y="95"/>
<variable formalParameter="IN2">
@@ -559,6 +554,13 @@
<expression>0</expression>
+ <inVariable localId="4" executionOrderId="0" height="30" width="60" negated="false"> + <position x="510" y="80"/> + <relPosition x="60" y="15"/> + <expression>Sloth</expression> --- a/tests/svghmi_v2/svghmi_0@svghmi/svghmi.svg Tue Sep 15 13:57:06 2020 +0200
+++ b/tests/svghmi_v2/svghmi_0@svghmi/svghmi.svg Thu Sep 17 11:30:22 2020 +0200
@@ -16,7 +16,7 @@
sodipodi:docname="svghmi.svg"
- inkscape:version="0.92.3 (2405546, 2018-03-11)"
+ inkscape:version="0.92.5 (0.92.5+68)" @@ -53,17 +53,6 @@
inkscape:vp_z="1272 : 385 : 1"
inkscape:persp3d-origin="536 : 237 : 1"
- inkscape:label="HMI:AccessList@Admin"
- inkscape:expanded="true">
inkscape:collect="always"
@@ -91,26 +80,6 @@
inkscape:connector-curvature="0" />
- inkscape:expanded="true"
- inkscape:label="HMI:Translate">
- xlink:href="#setting_jmp"
inkscape:collect="always"
xlink:href="#linearGradient962"
@@ -137,16 +106,16 @@
inkscape:document-units="px"
- inkscape:current-layer="g110-0-9"
+ inkscape:current-layer="hmi0" inkscape:zoom="1.4142136"
- inkscape:cx="437.24009"
- inkscape:cy="177.36896"
- inkscape:window-width="1800"
- inkscape:window-height="836"
+ inkscape:cx="462.89448" + inkscape:cy="318.79031" + inkscape:window-width="2503" + inkscape:window-height="1416" inkscape:window-maximized="1"
inkscape:guide-bbox="true" />
@@ -200,7 +169,7 @@
- id="tspan1409">100</tspan></text>
+ id="tspan1409">10</tspan></text> style="font-style:normal;font-weight:normal;font-size:10.58333302px;line-height:125%;font-family:sans-serif;text-align:center;letter-spacing:0px;word-spacing:0px;text-anchor:middle;fill:#ff6600;fill-opacity:1;stroke:none;stroke-width:0.26458332px;stroke-linecap:butt;stroke-linejoin:miter;stroke-opacity:1"
@@ -1221,7 +1190,7 @@
- id="tspan1409-1">100</tspan></text>
+ id="tspan1409-1">1000</tspan></text> style="font-style:normal;font-weight:normal;font-size:7.78479624px;line-height:125%;font-family:sans-serif;text-align:center;letter-spacing:0px;word-spacing:0px;text-anchor:middle;fill:#ff6600;fill-opacity:1;stroke:none;stroke-width:0.19461991px;stroke-linecap:butt;stroke-linejoin:miter;stroke-opacity:1"
@@ -1522,4 +1491,66 @@
style="fill:#ff00ca;fill-opacity:1;stroke:none;stroke-width:2.25346255px;stroke-opacity:1">000</tspan></text>
+ inkscape:label="HMI:ToggleButton@/TOGGLE2"> + inkscape:label="inactive" + style="opacity:1;fill:#ff0015;fill-opacity:1;stroke:none" /> + inkscape:label="active" + style="opacity:1;fill:#00ff03;fill-opacity:1;stroke:none" /> + transform="translate(-67.175138,-1.0606552)" + inkscape:label="HMI:ToggleButton@/TOGGLE1"> + inkscape:label="inactive" + style="opacity:1;fill:#ff0015;fill-opacity:1;stroke:none" /> + inkscape:label="active" + style="opacity:1;fill:#00ff03;fill-opacity:1;stroke:none" /> + transform="translate(63.639613)" + inkscape:label="HMI:ToggleButton@/TOGGLE"> + inkscape:label="active" + style="opacity:1;fill:#00ff03;fill-opacity:1;stroke:none" /> + inkscape:label="inactive" + style="opacity:1;fill:#ff0015;fill-opacity:1;stroke:none" />